NSFS | NC | Add Schema Validation to Bucket and Account Add and Update (NC NSFS CLI)

[shirady]

Explain the changes

1. Move the NC NSFS schema validation that we had in file src/sdk/bucketspace_fs.js (from PR NC | NSFS | Schema validation #7544) to a separate file (src/manage_nsfs/nsfs_schema_utils.js) to reuse it.
2. Edit the values of s3_policy and fs_backend to be undefined (and not empty '', as it passed as an argument).
3. Validate the data using schema and return an error in case it doesn't match (details would be passed according to the original message), using a mapping ManageCLIError.RPC_ERROR_TO_MANAGE.
4. Update the unit tests for the cases of s3_policy and fs_backend deletions (separate the argument that we pass as '' to the actual property that would be undefined).
5. Change the uid and gid extract in function fetch_account_data to be undefined when the argument user was passed (and not false).
6. Use schema_utils.strictify with option additionalProperties: false in the nsfs_account_schema and nsfs_bucket_schema.
7. Add the versioning enum to the bucket schema.
8. Add tests for the schema validation of nsfs_account_schema and nsfs_bucket_schema.

Issues: Fixed #7694

1. Add schema validation to bucket and account add and update - using NC NSFS CLI (fs_backend changes in a separate PR).
2. GAP - I couldn't ref bucket_api schema and had to duplicate the values, else got the error: Error: reference "bucket_api" resolves to more than one schema in the CI in job run-unit-tests.

Testing Instructions:

1. For tests that were edited, please run:
   sudo node ./node_modules/.bin/_mocha src/test/unit_tests/test_nc_nsfs_cli.js
sudo node ./node_modules/.bin/_mocha src/test/unit_tests/test_bucketspace_fs.js
2. For new tests, please run:
   npx jest test_nc_nsfs_schema_validation.test.js
   (no need for sudo permission, can see results live also with jest extension in VSCode).

• Doc added/updated
• Tests added
• Tests edited (see comment above)

[shirady]

Manual Testing Instructions:

Schema validation for buckets and accounts

First, create the FS_ROOT and give permissions:

mkdir -p /tmp/nsfs_root1
chmod 777 /tmp/nsfs_root1

This will be the argument for:

• new_buckets_path flag that we will use in the account commands
• path in the buckets commands.

In each case the commands work, hence we added the code change (to sabotage the created object and make sure that it creates an error, in each case we chose one of the properties that is required to be deleted.
for example in account add we would add this line:
data.email = undefined; // test
before passing to the schema validation, and see the error:
{
"error": {
"code": "InvalidSchema",
"message": "Schema invalid, please use required properties",
"detail": "must have required property 'email'"
}

Account add

1. Add account sudo node src/cmd/manage_nsfs account add --name <account-name> --email <account-email> --new_buckets_path /tmp/nsfs_root1 --uid <uid-number> --gid <gid-number>
2. Add deletion line of email.

Account update

1. Create an account (the account that we would update).
2. Update account sudo node src/cmd/manage_nsfs account update --name <account-name> --email <change-the-account-email>
3.  Add deletion line of email (in the first condition - it's neither a name update nor an access keys update).

Bucket add

1. Create an account (the account that we would create the bucket for it).
2. Add bucket sudo node src/cmd/manage_nsfs bucket add --name <bucket-name> --email <account-email> --path /tmp/nsfs_root1
3. Add deletion line of creation_date.

Bucket update

1. Create a bucket (the bucket that we would update).
2. Update bucket sudo node src/cmd/manage_nsfs account update --name <account-name> --email <change-the-account-email>
3. Add deletion line of creation_date (in the first condition - it's not a name update).

Remove bucket policy and FS backend:

First, Create bucket sudo node src/cmd/manage_nsfs bucket add --name <bucket-name> --email <account-email> --path /tmp/nsfs_root1 In the next commands please use the same <bucket-name> as you created here.

Bucket policy:

1. Add bucket policy: sudo node src/cmd/manage_nsfs bucket update --name <bucket-name> --bucket_policy '{"Version":"2012-10-17","Statement":[{"Effect":"Allow","Principal":{"AWS":["*"]},"Action":["s3:*"],"Resource":["arn:aws:s3:::<bucket-name>/*","arn:aws:s3:::<bucket-name>"]}]}' (replace the <bucket-name> in the bucket policy json argument as well)
2. Remove bucket policy: sudo node src/cmd/manage_nsfs bucket update --name <same-name-above> --bucket_policy ''

FS backend

1. Add FS backend: sudo node src/cmd/manage_nsfs bucket update --name <bucket-name> --fs_backend GPFS
2. Remove FS backend: sudo node src/cmd/manage_nsfs bucket update --name <bucket-name> --fs_backend ''

[romayalon]

@shirady please add automatic tests

[romayalon]

Approving, as mentioned on #7694, bucketspace_fs missing validations will be added in the next PR