-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | NC | NC Coretests changes - PR 2/3 #7720
Conversation
139cd6b
to
0e6fbc7
Compare
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
0e6fbc7
to
a657fb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comman doubt : - How this different from the normal test?
* @param {object} options | ||
* @returns {Promise<void>} | ||
*/ | ||
async function update_account_s3_access_manage(options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romayalon are we validating this account update anywhere else? just a doubt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on the tests, this function equal to the rpc function - update_account_s3_access(), the difference here is that on Non containerized version we don't have RPC server so we do the update by running manage NSFS cli calls instead and return rpc like response.
@naveenpaul1 The regular Coretest runs noobaa endpoint (and other components of noobaa core) and then a test can run full s3 flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WIP - This PR is dependent on merging #7719
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: