Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | Verify That Bucket Owner Exists #7728

Merged
merged 1 commit into from
Jan 21, 2024
Merged

NSFS | NC | Verify That Bucket Owner Exists #7728

merged 1 commit into from
Jan 21, 2024

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Jan 16, 2024 •
edited
Loading

Explain the changes

  1. Verify that the bucket owner exists when using bucket add and bucket update options from the NC NSFS CLI.
  2. Change the variable names in the test cli account list to match the test.

Issues: Fixed #7724

  1. Currently we can create and update a bucket with a bucket owner that doesn't exist.
  2. GAP - should improve performance of the implementation, iterate with concurrency, and the ability to stop the iteration once we find that the bucket owner account exists (more details, here).

Testing Instructions:

  1. Manual tests are described in the issue mentioned above.
  2. For running the unit test with the new tests, please run: sudo node ./node_modules/.bin/_mocha src/test/unit_tests/test_nc_nsfs_cli.js.
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Jan 16, 2024
@shirady
Copy link
Contributor Author

shirady commented Jan 16, 2024

Waiting for #7723 to be merged first before merging this PR.

romayalon
romayalon reviewed Jan 18, 2024
View reviewed changes
src/manage_nsfs/manage_nsfs_cli_errors.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_nc_nsfs_cli.js Outdated Show resolved Hide resolved
@shirady shirady force-pushed the verify-bucket-owner-exists branch 2 times, most recently from 10f7555 to a7a2075 Compare January 18, 2024 10:45
@shirady shirady requested a review from romayalon January 18, 2024 12:21
@shirady shirady force-pushed the verify-bucket-owner-exists branch from a7a2075 to 696d9d7 Compare January 21, 2024 13:44
@shirady
NSFS | NC | CLI | Bucket Create Should Check That We Have the Account
7f840cf 
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the verify-bucket-owner-exists branch from 696d9d7 to 7f840cf Compare January 21, 2024 14:51
@shirady shirady merged commit 09e6eb4 into noobaa:master Jan 21, 2024
9 checks passed
@shirady shirady deleted the verify-bucket-owner-exists branch January 21, 2024 15:30
@shirady shirady mentioned this pull request Feb 12, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

@liranmauda liranmauda Awaiting requested review from liranmauda

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

Assignees

@shirady shirady

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NSFS | NC | CLI | Bucket Create/Update Should Check That We Have the Account
2 participants
@shirady @romayalon