Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | Events | bugs & events addition to manage nsfs CLI #7759

Merged
merged 1 commit into from
Feb 8, 2024
Merged

NSFS | NC | Events | bugs & events addition to manage nsfs CLI #7759

merged 1 commit into from
Feb 8, 2024

Conversation

naveenpaul1
Copy link
Contributor

Explain the changes

  1. Currently there are no events created during the manage_nsfs cli usage
  2. Currently there are no buckets events
  3. bucketspace_fs.read_account_by_access_key() - has incorrect event
  4. bucketspace_fs.read_bucket_sdk_info() - we always throw noobaa_bucket_not_found event and it's not necessarily
    always the issue, need to be more specific.

Issues: Fixed #xxx / Gap #xxx

  1. NSFS | NC | Events bugs & events addition to manage nsfs CLI #7753

Testing Instructions:

  1. New events are added for account/bucket create/delete.
  2. Event added for whitelist update
  3. verify the events in var/logs/noobaa-events.log after running the CLI or S3 commands
  • Doc added/updated
  • Tests added

romayalon
romayalon reviewed Jan 25, 2024
View reviewed changes
docs/dev_guide/non_containerized_NSFS_events.md Outdated Show resolved Hide resolved
docs/dev_guide/non_containerized_NSFS_events.md Outdated Show resolved Hide resolved
src/sdk/bucketspace_fs.js Outdated Show resolved Hide resolved
src/sdk/bucketspace_fs.js Outdated Show resolved Hide resolved
@naveenpaul1 naveenpaul1 requested a review from romayalon January 31, 2024 10:58
romayalon
romayalon reviewed Feb 1, 2024
View reviewed changes
src/util/manage_nsfs_events_utils.js Outdated Show resolved Hide resolved
src/util/manage_nsfs_events_utils.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
@naveenpaul1 naveenpaul1 requested a review from romayalon February 5, 2024 07:02
@naveenpaul1
NSFS | NC | Events bugs & events addition to manage nsfs CLI
e00d1ab 
Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit 18ef8bc into noobaa:master Feb 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naveenpaul1 @romayalon