Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | Health script - PR 1/2 | new_buckets_path bug fixes #7765

Merged
merged 1 commit into from
Jan 29, 2024
Merged

NSFS | NC | Health script - PR 1/2 | new_buckets_path bug fixes #7765

merged 1 commit into from
Jan 29, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Jan 25, 2024 •
edited
Loading

Explain the changes

  1. Added handling for new_buckets_path access check when account has only user (distinguished name) and not uid and gid.
  2. CheckAcess/Stat only checked 'r' permission, now checking also 'w' permissions.
  3. Added jest unit tests for rw_check
  4. Added new tests to the health tests.
  5. refactored a bit the health script.

Issues: Fixed #xxx / Gap #xxx

  1. In the next PR i'll add the same check to manage_nsfs create/update account.

Testing Instructions:

  1. sudo jest --testRegex=jest_tests/test_nc_nsfs_new_buckets
  2. sudo node mocha noobaa-core/src/test/unit_tests/test_nc_nsfs_health.js
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-create-account-invalid-access branch 2 times, most recently from 2e1ed11 to 562f31a Compare January 29, 2024 08:41
naveenpaul1
naveenpaul1 approved these changes Jan 29, 2024
View reviewed changes
src/cmd/health.js Outdated
const new_err = new Error('ACCESS DENIED');
new_err.code = 'EACCES';
throw new_err;
// err_code = health_errors.ACCESS_DENIED.error_code;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove comment

@romayalon romayalon force-pushed the romy-create-account-invalid-access branch 2 times, most recently from 9d6563d to d33ca4d Compare January 29, 2024 13:24
@romayalon
start account check access check
408eca8 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-create-account-invalid-access branch from 842b324 to 408eca8 Compare January 29, 2024 13:45
@romayalon romayalon merged commit 9cffd85 into noobaa:master Jan 29, 2024
10 checks passed
@romayalon romayalon mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romayalon @naveenpaul1