NSFS | NC | Use --from_file Option in Account Create
#7779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirady
changed the title
--from-File Option without creation_date--from-file Option without creation_date
This comment was marked as outdated.
This comment was marked as outdated.
romayalon
reviewed
Feb 1, 2024
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
from
336c2ec to
a4ecfbe
Compare
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
from
a4ecfbe to
6d052bf
Compare
shirady
changed the title
--from-file Option without creation_date--from-file Option in Account Create
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
2 times, most recently
from
7669e00 to
3127b3e
Compare
romayalon
reviewed
Feb 18, 2024
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
from
03df133 to
114aa0e
Compare
romayalon
reviewed
Feb 26, 2024
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
3 times, most recently
from
4e75204 to
7a6444f
Compare
2 tasks
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
3 times, most recently
from
87eab91 to
a7960bc
Compare
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
4 times, most recently
from
79986b9 to
46187c4
Compare
romayalon
approved these changes
Mar 7, 2024
1. Add the from_file option in the account that would include validation. The JSON file will include options (as key-value structure) that are the same as the flags we suggest. 2. Change the structure inside the main so that eventually it doesn't matter whether the parameters are from the flags arguments (argv) or file. 3. Move get_access_keys to a separate function. 4. Fix indentation in fetch_account_data in the part of access_key as SensitiveString. 5. Remove an unused parameter from validate_options_type_by_value. 6. In native_fs_utils.js rename the function read_config_file to read_file. 7. Update json in doc so _id will appear first (as fixed in this PR). Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
nsfs-nc-fix-creation-date-from-file
branch
from
46187c4 to
0796e79
Compare
2 tasks
shirady
changed the title
--from-file Option in Account Create--from-_file Option in Account Create
shirady
changed the title
--from-_file Option in Account Create--from_file Option in Account Create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
from_fileoption in the account that would include validation. The JSON file will include options (as key-value structure) that are the same as the flags we suggest.get_access_keysto a separate function.fetch_account_datain the part ofaccess_keyasSensitiveString.validate_options_type_by_value.native_fs_utils.jsrename the functionread_config_filetoread_file._idwill appear first (as fixed in this PR).Issues: Fixed BZ 2260325, BZ 2262997, BZ 2262992
--from_fileand in the JSON there is nocreation_dateproperty we do not allow the account creation (it fails on the schema validation).--from_filethe account credentials standards were not checked.allow_bucket_creation#7827 to be merged before merging this PR.set_access_keys()function.Testing Instructions:
Added unit tests, please run:
sudo npx jest test_nc_nsfs_account_cli.test.js