NSFS | NC | CLI | Account add/update when uid = 0 and gid != 0 bug fix

[romayalon]

Explain the changes

1. is_undefined() checks using if (!value), which return true when uid/gid is 0, causing the account add/update to fail.

Issues: Fixed #xxx / Gap #xxx

1. Fixed NSFS | NC | CLI | Account add/update is failing when uid = 0 and gid != 0 and vice versa #7787

Testing Instructions:

1. manage_nsfs.js account add --name foo --email foo@example.com --uid 0 --gid 10 2>/dev/null

• Doc added/updated
• Tests added

[shirady]

@romayalon please notice there is a similar issue that is not covered by this fix:
sudo node src/cmd/manage_nsfs account add --name foo --email foo@example.com --user 0 (user name is 0).

{
  "error": {
    "code": "InvalidAccountNSFSConfig",
    "message": "Account config should not be empty, should contain UID, GID or user",
    "detail": {
      "distinguished_name": 0
    }
  }
}

[romayalon]

@shirady As discussed on Slack - this is a different type of issue that will addressed by replacing the STRING_OR_NUMBER type with string only.

@romayalon please notice there is a similar issue that is not covered by this fix: sudo node src/cmd/manage_nsfs account add --name foo --email foo@example.com --user 0 (user name is 0).

{
  "error": {
    "code": "InvalidAccountNSFSConfig",
    "message": "Account config should not be empty, should contain UID, GID or user",
    "detail": {
      "distinguished_name": 0
    }
  }
}

[shirady]

You can leave the comment unhandled and mentioned it as a GAP (the fix is more important)

[shirady]

If it will not be temporary as we want (as mentioned in the comment) I would consider these points:

• If you can add a JSDoc to the function.
• I prefer functions with verbs and change the variable name to indicate that it should only be used for names., for example:

Suggested change

	function is_string_undefined(value) {
	function check_string_undefined(str) {

• Edge case - what will be when someone uses a bucket or an account with the name 0? (it still can happen, unlike a user with 0 that will be removed).

[romayalon]

bucket and account are SensitiveStrings and on SensitiveString we check str.unwrap() === 'undefined'