Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Fail nsfs.js completely on system.json failure #7858

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Currently on nsfs.js system.json update issues we fail silently and keep running the endpoint even if got an error, we need to fail the whole NSFS service in this case.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed Noobaa is not starting the service by reading the configuration stored in the mount system post the system reboot.  #7857
  2. we might need to think about more cases this could happen.

Testing Instructions:

  1. start nsfs service before the config dir mounting is available.
  2. (This can also easily be mocked by throwing an error from init_nsfs_system() try scope).
  • Doc added/updated
  • Tests added

Copy link
Member

@tangledbytes tangledbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this makes sense. I think when I first added this, I deemed this failure to be non-critical (don't think it was valid assumption even then though).

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-fix-startup-failures branch from 4444009 to d4264be Compare March 3, 2024 09:12
@romayalon romayalon merged commit 7d2248c into noobaa:master Mar 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants