Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | health giving trimmed output in pipe #7898

Merged
merged 1 commit into from
Mar 13, 2024
Merged

NSFS | NC | health giving trimmed output in pipe #7898

merged 1 commit into from
Mar 13, 2024

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Mar 13, 2024

Explain the changes

  1. if the size of health output is bucket/account details output getting trimmed when using with pipe
    usr/local/noobaa-core/bin/node /usr/local/noobaa-core/src/cmd/health --all_bucket_details | cat
  2. Update timeout for test_nc_nsfs_account_cli.test.js
  3. remove unused iam_json_schema and iam_ttl

with pipe cat or tee operation getting first batch of output and before flushing second set of data process is getting exited for health command. This change will remove the process.exit() from code and make sure complete output is printed/saved to terminal/file

Issues: Fixed #xxx / Gap #xxx

  1. Noobaa health command giving trimmed output in pipe #7894

Testing Instructions:

  1. run below command and make sure output size more than 64 bytes
    usr/local/noobaa-core/bin/node /usr/local/noobaa-core/src/cmd/health --all_bucket_details | cat
  • Doc added/updated
  • Tests added

Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if my suggestion above works

src/cmd/health.js Outdated Show resolved Hide resolved
@naveenpaul1 naveenpaul1 requested a review from guymguym March 13, 2024 11:09
Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit 18eb0ea into noobaa:master Mar 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants