bucket_logging: Change bucket API's and functions as per schema #7901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspandey
force-pushed
the
bucket_schema_sync
branch
2 times, most recently
from
3fcdc92 to
ca11f1a
Compare
liranmauda
reviewed
Mar 14, 2024
We do not store name of the bucket, on which we are setting bucket logging, in bucket schema. There is no need to return that name as part of get_bucket_logging and store it as part of put_bucket_logging Also, made changed to return a correct value in case of bucket logging is configured for a bucket. Signed-off-by: Ashish Pandey <aspandey@redhat.com>
aspandey
force-pushed
the
bucket_schema_sync
branch
from
ca11f1a to
3587c8e
Compare
liranmauda
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not store name of the bucket, on which we are setting bucket logging, in bucket schema.
There is no need to return that name as part of get_bucket_logging and store it as part of put_bucket_logging
Also, made changed to return a correct value in case of bucket logging is configured for a bucket.