Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Symlinks should contain a relative path #7916

Merged
merged 1 commit into from
Mar 21, 2024
Merged

NSFS | NC | Symlinks should contain a relative path #7916

merged 1 commit into from
Mar 21, 2024

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Mar 20, 2024

Explain the changes

  1. Symling target path is changed to relative path (../accounts/account_name.json)

Issues: Fixed #xxx / Gap #xxx

  1. Symlinks under "s3-config/access_keys" should contain a relative path rather absolute path #7914

Testing Instructions:

  1. create account and check the symlink should have relative path instead of absolute path

root:access_keys# ls -lrt access_keys/
total 8
lrwxrwxrwx. 1 root root 29 Mar 20 12:36 kuDO2k8ahqvrju8clh2P.symlink -> ../accounts/acc_symlink1.json

  • Doc added/updated
  • Tests added

src/cmd/manage_nsfs.js Show resolved Hide resolved
src/cmd/manage_nsfs.js Show resolved Hide resolved
@naveenpaul1 naveenpaul1 marked this pull request as draft March 20, 2024 12:17
@naveenpaul1 naveenpaul1 marked this pull request as ready for review March 21, 2024 04:33
Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit 8e96a09 into noobaa:master Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants