-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug BZ 2271067 | NSFS | Change Mapping in Pool Server #7936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romayalon
reviewed
Mar 31, 2024
romayalon
reviewed
Apr 1, 2024
romayalon
reviewed
Apr 1, 2024
liranmauda
reviewed
Apr 1, 2024
shirady
force-pushed
the
nsfs-bz-namespacestore
branch
from
April 1, 2024 11:46
587c307
to
63ef435
Compare
shirady
force-pushed
the
nsfs-bz-namespacestore
branch
from
April 1, 2024 11:48
63ef435
to
86d7c6e
Compare
shirady
force-pushed
the
nsfs-bz-namespacestore
branch
3 times, most recently
from
April 2, 2024 09:28
a3d1184
to
81fd35e
Compare
romayalon
reviewed
Apr 2, 2024
shirady
force-pushed
the
nsfs-bz-namespacestore
branch
from
April 2, 2024 10:42
81fd35e
to
051a489
Compare
romayalon
approved these changes
Apr 2, 2024
shirady
force-pushed
the
nsfs-bz-namespacestore
branch
2 times, most recently
from
April 3, 2024 06:37
95d337e
to
209c375
Compare
1. In pool_server inside calc_namespace_resource_mode remove the mapping of ENOENT to storage_not_exist. 2. In the namespace_monitor change the error code either from a thrown error or an error that we created to a code that we choose and add log printing (could be seen in the endpoint logs). 3. Add config NS_MAX_ALLOWED_IO_ERRORS that we will use in the calc_namespace_resource_mode. Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
shirady
force-pushed
the
nsfs-bz-namespacestore
branch
from
April 3, 2024 06:56
209c375
to
07b195c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
pool_server
insidecalc_namespace_resource_mode
remove the mapping ofENOENT
tostorage_not_exist
.namespace_monitor
change the error code either from a thrown error or an error that we created to a code that we choose and add log printing (could be seen in the endpoint logs).NS_MAX_ALLOWED_IO_ERRORS
that we will use in thecalc_namespace_resource_mode
.Issues: Fixed BZ 2271067
ENOENT
and then the namespace mode will beSTORAGE_NOT_EXISTS
(instead ofIO_ERROR
).NoSuchBucket
orAccessDenied
error code is from the namespace monitor or requests that were updated in the issues report (we would only have the printing in the endpoint logs to guide us that it is from the namespace monitor, example:Testing Instructions:
Manual Tests:
General:
Mapping Change:
Use AWS CLI and use the head-object command on a noobaa bucket in NSFS on non-existing key.
Ready
toRejected
with modeSTORAGE_NOT_EXIST
after 1 failure.Ready
toRejected
with modeIO_ERRORS
after a couple of failures.You can use a loop for this, for example:
for i in {1..10}; do s3-nb-user-1 s3api head-object --bucket fs1-jenia-bucket --key non_exist.txt; done
(s3-nb-user-1
is an aliasalias s3-nb-user-1='AWS_ACCESS_KEY=<access_key_nsfs_account> AWS_SECRET_ACCESS_KEY=<secret_access_key_nsfs_account> aws --no-verify-ssl --endpoint-url https://localhost:12443'
.Updating the env:
If you wish to update the
NS_MAX_ALLOWED_IO_ERRORS
you would need to:kubectl exec statefulset/noobaa-core -c core -- printenv | grep IO_ERRORS
(should be empty).kubectl set env statefulset/noobaa-core CONFIG_JS_NS_MAX_ALLOWED_IO_ERRORS=3
(a different number that we defined in the config, then it should outputstatefulset.apps/noobaa-core env updated
andnoobaa-core-0
pod will be terminated and start running again). Please notice that to override envs we will need to add the prefixCONFIG_JS_
in the variable name.kubectl exec statefulset/noobaa-core -c core -- printenv | grep IO_ERRORS
(should beNS_MAX_ALLOWED_IO_ERRORS=6
).for i in {1..7};
and see that the namespace phase was changed fromReady
toRejected
with modeSTORAGE_NOT_EXIST
.