Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bucket_logging: Store log objects inside log prefix directory #7950

Merged
merged 1 commit into from
Apr 12, 2024
Merged

bucket_logging: Store log objects inside log prefix directory #7950

merged 1 commit into from
Apr 12, 2024

Conversation

aspandey
Copy link
Contributor

@aspandey aspandey commented Apr 4, 2024

We provide log prefix while setting bucket logging for a noobaa bucket. When log objects are uploaded on log bucket, it should be saved under a directory named as log prefix.

@aspandey aspandey force-pushed the bucket_log_testing branch 3 times, most recently from 790b53b to 99f892b Compare April 4, 2024 07:40
@aspandey
Copy link
Contributor Author

aspandey commented Apr 8, 2024

Logs on log buckets would look like as follows -
ashishpandey:noobaa-operator$ s3 ls s3://log.bucket/
PRE data-bucket-logs/
PRE first-bucket-logs/

ashishpandey:noobaa-operator$ s3 ls s3://log.bucket/data-bucket-logs/
2024-04-04 11:50:45 50033 log.bucket_data-bucket-logs_2024-04-04-06-20-23.632485695.log
2024-04-04 11:55:40 50113 log.bucket_data-bucket-logs_2024-04-04-06-20-45.542262765.log
2024-04-05 14:56:26 50121 log.bucket_data-bucket-logs_2024-04-05-09-25-15.607879698.log
2024-04-05 15:01:32 50121 log.bucket_data-bucket-logs_2024-04-05-09-30-11.960185164.log
2024-04-05 15:01:32 50116 log.bucket_data-bucket-logs_2024-04-05-09-30-55.958858357.log

ashishpandey:noobaa-operator$ s3 ls s3://log.bucket/first-bucket-logs/
2024-04-05 14:51:26 50156 log.bucket_first-bucket-logs_2024-04-05-09-20-11.902376564.log
2024-04-05 14:56:26 50256 log.bucket_first-bucket-logs_2024-04-05-09-25-03.806907221.log
2024-04-05 14:56:26 50247 log.bucket_first-bucket-logs_2024-04-05-09-25-27.718127795.log
2024-04-05 15:01:32 50247 log.bucket_first-bucket-logs_2024-04-05-09-30-33.059334529.log

liranmauda
liranmauda approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aspandey
bucket_logging: Store log objects inside log prefix directory
0735f5c 
We provide log prefix while setting bucket logging for a noobaa bucket.
When log objects are uploaded on log bucket, it should be
saved under a directory named as log prefix.

Signed-off-by: Ashish Pandey <aspandey@redhat.com>
@aspandey aspandey force-pushed the bucket_log_testing branch from 99f892b to 0735f5c Compare April 12, 2024 06:29
@aspandey aspandey merged commit 2f9dcb6 into noobaa:master Apr 12, 2024
10 checks passed
@aspandey aspandey deleted the bucket_log_testing branch April 12, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspandey @liranmauda