[NC | NSFS] use fixed hh:mm for running expiry script
#7952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
changed the title
hh:mmhh:mm for running expiry script
tangledbytes
force-pushed
the
utkarsh/feat/run-expiry-hh-mm
branch
from
7aa83d7 to
10c9698
Compare
guymguym
reviewed
Apr 9, 2024
guymguym
reviewed
Apr 9, 2024
tangledbytes
force-pushed
the
utkarsh/feat/run-expiry-hh-mm
branch
from
10c9698 to
c07d67d
Compare
guymguym
reviewed
Apr 10, 2024
guymguym
reviewed
Apr 10, 2024
tangledbytes
force-pushed
the
utkarsh/feat/run-expiry-hh-mm
branch
2 times, most recently
from
863f8a3 to
c534023
Compare
guymguym
reviewed
Apr 10, 2024
Comment on lines
111
to
126
| if (config.NSFS_GLACIER_EXPIRY_TZ === 'UTC') { | ||
| min_time.setUTCHours(desired_hour); | ||
| min_time.setUTCMinutes(desired_min); | ||
| } else { | ||
| min_time.setHours(desired_hour); | ||
| min_time.setMinutes(desired_min); | ||
| } | ||
|
|
||
| const max_time = new Date(); | ||
| if (config.NSFS_GLACIER_EXPIRY_TZ === 'UTC') { | ||
| max_time.setUTCHours(desired_hour); | ||
| max_time.setUTCMinutes(desired_min + tolerate_mins); | ||
| } else { | ||
| max_time.setHours(desired_hour); | ||
| max_time.setMinutes(desired_min + tolerate_mins); | ||
| } |
There was a problem hiding this comment.
can you refactor this to a utility function to avoid copy-pasta issues?
There was a problem hiding this comment.
also don't we need to set the seconds and millis to 0?
There was a problem hiding this comment.
I have set the secs to 0 now but not millis. Considering the granularity is minutes, does it matter?
There was a problem hiding this comment.
I would prefer it to be clear and not have random millis.
tangledbytes
force-pushed
the
utkarsh/feat/run-expiry-hh-mm
branch
from
c534023 to
84d6ca5
Compare
tangledbytes
force-pushed
the
utkarsh/feat/run-expiry-hh-mm
branch
2 times, most recently
from
b22e7b4 to
0e5d583
Compare
guymguym
approved these changes
Apr 10, 2024
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> address PR comments Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> set millis to 0 Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh/feat/run-expiry-hh-mm
branch
from
0e5d583 to
90a2fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR moves away from running expiry script on certain interval and instead use a configurable
hh:mmor when the disk is running low on space.The granularity is minutes instead of seconds to account for scheduler mess ups.