Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github stale action #7990

Merged
merged 1 commit into from
Apr 24, 2024
Merged

github stale action #7990

merged 1 commit into from
Apr 24, 2024

Conversation

guymguym
Copy link
Member

Explain the changes

  1. We have too many stale issues and PR's.
  2. Added the stale action.

@guymguym guymguym requested a review from nimrod-becker April 21, 2024 20:18
@guymguym guymguym force-pushed the guy-github-stale-action branch from ccd89bf to ea15bfa Compare April 21, 2024 20:21
@nimrod-becker
Copy link
Contributor

Ack.
Didnt notice the stale bot was deprecated

with:
days-before-stale: 60
days-before-pr-stale: 60
days-before-issue-stale: 60
Copy link
Contributor

@nimrod-becker nimrod-becker Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

days-before-issue-stale too little of an interval. Lets set to 180 days

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 6 months is too much. I would keep it 90 days, and if it gets stale we can always post a comment or remove the stale label to avoid closing it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90 days in the issue list are still things we don't want to lose. It's too short.
You will still get your value with 180 days

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't close after 90, we only mark stale.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently in this config it will close if there is no update for another 30 days after labeling as stale

@guymguym guymguym force-pushed the guy-github-stale-action branch from ea15bfa to 0e8526f Compare April 24, 2024 09:29
Signed-off-by: Guy Margalit <guymguym@gmail.com>
@guymguym guymguym force-pushed the guy-github-stale-action branch from 0e8526f to 065eb90 Compare April 24, 2024 09:30
@guymguym guymguym merged commit 2fd623a into master Apr 24, 2024
18 checks passed
@guymguym guymguym deleted the guy-github-stale-action branch April 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants