NC | CLI | Restrict Access Keys chars + performance improvement #8008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guymguym
requested changes
May 5, 2024
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
romayalon
force-pushed
the
romy-restrict-access-keys-chars
branch
from
9a178fc to
c7a4eb4
Compare
guymguym
approved these changes
May 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
a. Length = 20.
b. Contains only alphanumeric chars.
a. Length = 40.
b. Contains only alphanumeric chars, "+", "/".
Before the change, we tested 4 different regexp on the same access_key/secret_key, now we do it once.
Issues: Fixed #xxx / Gap #xxx
+) #7931Testing Instructions:
sudo jest --testRegex=jest_tests/test_nc_nsfs_account_cli