Add editorconfig #8045
Merged
Add editorconfig #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
requested review from
a team and
liranmauda
and removed request for
a team
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add editorconfig for native code as well Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh/add/editorconfig
branch
from
557de49 to
3030da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR adds editorconfig for JS and native code.
Justification
EditorConfig is widely supported in most of editors/IDEs - Goland (and other JetBrains IDEs), Neovim, VSCode (extention), emacs (extension), etc. This should really help in automatically configuring the editors in setting up tabs/spaces etc.
I have accidentally committed code with tabs for indentation as my editor was unaware of the styling guide, this is to minimize the chances of such future accidents.