Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed construct_url to handle ipv6 addresses #8112

Merged
merged 1 commit into from
Jun 9, 2024
Merged

fixed construct_url to handle ipv6 addresses #8112

merged 1 commit into from
Jun 9, 2024

Conversation

dannyzaken
Copy link
Contributor

@dannyzaken dannyzaken commented Jun 5, 2024 •
edited
Loading

Signed-off-by: Danny Zaken dannyzaken@gmail.com

Explain the changes

  • When an IPV6 address is used as a hostname, it must be wrapped with square brackets.
  • Fixed construct_url to check if the hostname is IPV6 and wrap it
  • Catch all errors in _list_s3_addresses
  • Added test_url_utils.test.js

Issues: Fixed #xxx / Gap #xxx

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2284652

Testing Instructions:

  1. Requires deployment of noobaa-operator with an ipv6 external IP
  • Doc added/updated
  • Tests added

@dannyzaken dannyzaken requested review from liranmauda and shirady June 5, 2024 13:46
liranmauda
liranmauda approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannyzaken
fixed construct_url to handle ipv6 address
fa88d8d 
* When an IPV6 address is used as a hostname it has to be wrapped with square brackets.
* fixed construct_url to check if the hostname is IPV6 (contains ':') and is not wrapped already.
* catch all errors in _list_s3_addresses

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>

test list objects fix

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>

Revert "test list objects fix"

This reverts commit 7c26d54.

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@dannyzaken dannyzaken merged commit 4626796 into noobaa:master Jun 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

@guymguym guymguym guymguym approved these changes

@shirady shirady Awaiting requested review from shirady

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannyzaken @guymguym @liranmauda