[Guaranteed Bucket Logging][NSFS]PR3 - Persistent logging #8121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyalbo
changed the title
jackyalbo
requested review from
romayalon,
guymguym,
dannyzaken and
tangledbytes
jackyalbo
force-pushed
the
jacky-pers_log
branch
7 times, most recently
from
3626357 to
dcb0649
Compare
| bucket_streams[source_bucket].write(entry + '\n'); | ||
| }); | ||
| Object.values(bucket_streams).forEach(st => st.end()); | ||
| await Promise.all(promises); |
There was a problem hiding this comment.
Do we need to support the scenarios where uploads are failing to just a selected few buckets but not others? Right now I think we would keep retrying it for the entire log file if the upload fails even just once.
There was a problem hiding this comment.
maybe it's a good idea to cover the promises with retries as well...thanks
There was a problem hiding this comment.
Added a check on if the bucket doesn't exist and 3 retries
jackyalbo
force-pushed
the
jacky-pers_log
branch
4 times, most recently
from
8fdeb6f to
a277d0a
Compare
dannyzaken
reviewed
Jul 1, 2024
jackyalbo
force-pushed
the
jacky-pers_log
branch
9 times, most recently
from
b7b0ff1 to
34e59d8
Compare
dannyzaken
approved these changes
Jul 8, 2024
jackyalbo
force-pushed
the
jacky-pers_log
branch
from
54986ca to
767db73
Compare
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
jackyalbo
force-pushed
the
jacky-pers_log
branch
from
767db73 to
30bd125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: