NSFS | MPU | Disable ctime check on load_multipart() #8158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Background -
Checking ctime on the upload id directory does not make sense because for a directory, ctime changes when any of its attributes or contents (like adding or removing files) are modified.
For instance -
Notice that the ctime changed after adding a file to the directory, therefore, on concurrent upload of parts we will see ctime changes of the upload id directory.
Changes -
Disabled ctime checking on the mpu_path stat.
Notice it'll affect all the calling functions to load_multipart() -
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
wait for the upload to finish.