Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Add --debug flag to health CLI #8165

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Jun 25, 2024

Explain the changes

  1. Added --debug flag to Health CLI for supporting higher debug logs on the Health CLI process.
  2. Merged set_debug_level() code to a single function from various places.

Testing Instructions:

  1. Manual -
    Run - sudo node src/cmd/health --debug=5 and check for logs from higher levels, for example -
    Jun-25 17:52:23.987 [/46080] [L2] core.util.http_utils:: should_proxy: hostname undefined isIp false
  • Doc added/updated
  • Tests added

Copy link
Contributor

@jackyalbo jackyalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice...

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-health-debug branch from 218a426 to e8b44aa Compare June 30, 2024 09:28
@romayalon romayalon merged commit ec7a200 into noobaa:master Jun 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants