Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing an error in tier_server.update_bucket_class #8173

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

dannyzaken
Copy link
Member

Explain the changes

  1. If a newly generated tier name already exists, regenerate it instead of failing the entire operation.
  2. This could happen if update_bucket_class is called too frequently and new_name is generated in the exact second.
  3. The name itself has no significance, except that it is used as a unique DB index key. This is the main reason to keep it unique

Issues: Fixed #xxx / Gap #xxx

  1. https://bugzilla.redhat.com/show_bug.cgi?id=2294723

Testing Instructions:

  1. perform frequent updates to the a bucketclass or the backingstores that are in its policy
  • Doc added/updated
  • Tests added

If a newly generated tier name already exists, regenerate it instead of failing the entire operation.

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@dannyzaken dannyzaken merged commit 7b0d3e3 into noobaa:master Jul 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants