Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace yamljs with yaml #8184

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Replace yamljs with yaml #8184

merged 1 commit into from
Jul 7, 2024

Conversation

liranmauda
Copy link
Contributor

Explain the changes

  1. Replace yamljs with yaml

@liranmauda liranmauda force-pushed the liran-replace-yamljs branch from 69e7537 to f2fec47 Compare July 4, 2024 08:06
@liranmauda
Copy link
Contributor Author

Replacing yamljs with yaml as yaml is maintained and yamljs is less maintained.
This is the first step, in the second step we should avoid using any kubernetes calls in the core
@dannyzaken @jackyalbo WDYT?

@liranmauda
Replace yamljs with yaml
a044c30 
Replace yamljs with yaml

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda force-pushed the liran-replace-yamljs branch from f2fec47 to a044c30 Compare July 7, 2024 07:45
@liranmauda liranmauda merged commit 4eec949 into noobaa:master Jul 7, 2024
10 checks passed
@liranmauda liranmauda deleted the liran-replace-yamljs branch July 7, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@dannyzaken dannyzaken Awaiting requested review from dannyzaken

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liranmauda @jackyalbo