fix vue-template-compiler error

[toolboc]

• fixes Error: vue-template-compiler must be installed as a peer dependency #78

[noopkat]

@toolboc thanks for this fix! 😄
My gut feel is that we should keep this Vue toolchain library as a devDependency like in #75

Thoughts?

[mtheoryx]

This does fix it in a similar way as #75 !

On separating devDepedencies, I see what you mean @noopkat and I generally would do that. However, I got curious and ran across this issue where Dan Abramov talked about why they moved something into dependencies:

facebook/create-react-app#2696

tl;dr As opposed to something like test runners and assertion libraries, vue-template-compiler is required at build time. Their argument over on that issue was that some deployment providers treat it such that only 'dependencies' are needed for a build, and they were running into issues.

So, I'm totally on the fence about whether we do or not! If we want to do this, I can update my #75 quickly if we merge this. @mpaarating Thoughts?

[mpaarating]

My gut reaction is that it should stay in devDependencies as the deployment issue that Mr. Abramov (blessed his name) referenced shouldn't be an issue in this project. With that said, I don't have that strong of feelings either way.

[toolboc]

I was able to verify that the changes from @mtheoryx in #75 provide the same error relief. I say we go in favor of that PR due to keeping everything in devDepencies along with the additional changes it brings. The duplication was due to my not noticing that a PR was already in place, however, we now have independent verification that @mtheoryx 's changes are good to go!

*closing

[mtheoryx]

@toolboc No worries, kind of a funny coincidence we both stumbled on this at the same time Thank you for also trying to track it down!