Use InPlacePodVerticalScaling feature gate instead of tweaking cgroups #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version (also tagged v0.1.0) is tweaking cgroups to update the CPU requests/limits.
It works, but there are many downsides:
On Kubernetes 1.27, the alpha feature gate
InPlacePodVerticalScaling
was introduced (docs here), and this allows to change the CPU without restarting the pod, accomplishing exactly what we're trying to achieve.The only downsides of using this (that I can see) are:
InPlacePodVerticalScaling
feature gate is only available from 1.27, so older versions might need to use the "tweaking cgroups" solution in order to boost the pods at startupStill, there are more benefits overall than downsides.