Merge pull request #104 from norcalipa/noraclipa/refactoring-actions-10

fixing deployment.yml env vars
norcalipa · Apr 5, 2024 · 4b76173 · 4b76173
2 parents 721e4ff + 4d739c7
commit 4b76173
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/k8s/deployment.yml b/k8s/deployment.yml
@@ -12,7 +12,7 @@ metadata:
   labels:
     app.kubernetes.io/name: crank
     app.kubernetes.io/instance: crank
-    app.kubernetes.io/version: $(GITHUB_SHA)
+    app.kubernetes.io/version: $GITHUB_SHA
 
 spec:
   replicas: 1
@@ -30,7 +30,7 @@ spec:
     spec:
       containers:
       - name: crank-container
-        image: ghcr.io/norcalipa/crank/crank:$(GITHUB_SHA)
+        image: ghcr.io/norcalipa/crank/crank:$GITHUB_SHA
         ports:
           - name: http
             containerPort: 8080
@@ -62,7 +62,7 @@ metadata:
   labels:
     app.kubernetes.io/name: crank
     app.kubernetes.io/instance: crank
-    app.kubernetes.io/version: $(GITHUB_SHA)
+    app.kubernetes.io/version: $GITHUB_SHA
 spec:
   type: NodePort
   ports: