Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Element Web guest module to Element Web version 1.11.84 or later #183

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

weeman1337
Copy link
Contributor

  • Changes the import path of React SDK; see code comments
  • Now requires Element Web >= 1.11.84 (release where Element Web included Matrix React SDK)

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@weeman1337 weeman1337 force-pushed the nic/fix/PX4-84-element-web-guest-module branch from f171777 to 3dc2c34 Compare November 15, 2024 07:44
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
@weeman1337 weeman1337 force-pushed the nic/fix/PX4-84-element-web-guest-module branch from cbe9968 to 3a35199 Compare November 15, 2024 10:05
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
Signed-off-by: Michael Weimann <michael.weimann@nordeck.net>
@weeman1337 weeman1337 marked this pull request as ready for review November 15, 2024 10:15
@weeman1337 weeman1337 requested a review from a team as a code owner November 15, 2024 10:15
@HarHarLinks HarHarLinks self-requested a review November 15, 2024 10:15
@weeman1337 weeman1337 mentioned this pull request Nov 15, 2024
5 tasks
Copy link
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and tested working with 1.11.84

@weeman1337 weeman1337 enabled auto-merge (squash) November 15, 2024 13:25
@weeman1337 weeman1337 merged commit 374bc3f into main Nov 15, 2024
5 checks passed
@weeman1337 weeman1337 deleted the nic/fix/PX4-84-element-web-guest-module branch November 15, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants