Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CI to build several Element + module configurations #188

Merged
merged 26 commits into from
Nov 21, 2024
Merged

add CI to build several Element + module configurations #188

merged 26 commits into from
Nov 21, 2024

Conversation

HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Nov 18, 2024 •
edited
Loading

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

HarHarLinks
HarHarLinks commented Nov 18, 2024
View reviewed changes
Copy link
Contributor Author

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how to test this, act fails with 85 lines of errors

.github/workflows/element-with-modules.yml Outdated Show resolved Hide resolved
@HarHarLinks HarHarLinks marked this pull request as ready for review November 18, 2024 18:01
@HarHarLinks HarHarLinks requested a review from a team as a code owner November 18, 2024 18:01
@HarHarLinks
add CI to build several Element + module configurations
7369a69 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
improve CI
d935271 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks HarHarLinks force-pushed the nic/feat/PX4-85-widgetready branch from e0b49e8 to d935271 Compare November 19, 2024 11:39
weeman1337
weeman1337 reviewed Nov 19, 2024
View reviewed changes
.github/workflows/element-with-modules.yml Outdated Show resolved Hide resolved
.github/workflows/element-with-modules.yml Outdated Show resolved Hide resolved
.github/workflows/element-with-modules.yml Outdated Show resolved Hide resolved
.github/workflows/element-with-modules.yml Outdated Show resolved Hide resolved
@HarHarLinks @weeman1337
Update .github/workflows/element-with-modules.yml
0b50f75 
Co-authored-by: Michael Weimann <mail@michael-weimann.eu>
Signed-off-by: Kim Brose <2803622+HarHarLinks@users.noreply.github.com>
@HarHarLinks
syntax fixes
64b24d9 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
fix checkout syntax
3b10eab 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
fix some variables
93e889f 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
weeman1337
weeman1337 reviewed Nov 19, 2024
View reviewed changes
.prettierignore Outdated Show resolved Hide resolved
@HarHarLinks
fix determine versions step
4de28b9 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
fix matrix, fix cron, update push condition
3a88d7c 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
bash is not a programming language
6584751 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
fix tags
cb5f2ff 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
back to nordeck runner
7a6f8c4 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
switch determine-versions to ubuntu runner
220ca54 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
fetch more git tags
b943287 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks HarHarLinks force-pushed the nic/feat/PX4-85-widgetready branch from 2ed0c2a to 9a29b65 Compare November 19, 2024 16:49
@HarHarLinks
fetch even more tags
62a1674 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks HarHarLinks force-pushed the nic/feat/PX4-85-widgetready branch from 9a29b65 to 62a1674 Compare November 19, 2024 16:51
@HarHarLinks
Copy link
Contributor Author

CI needs a fix by @helletheone

@helletheone
Copy link
Contributor

CI needs a fix by @helletheone

done :)

@HarHarLinks
Revert "switch determine-versions to ubuntu runner"
ad407b3 
This reverts commit 220ca54.

Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
turn prettier back on
9dc1683 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks HarHarLinks force-pushed the nic/feat/PX4-85-widgetready branch from b5798c0 to 9dc1683 Compare November 20, 2024 09:02
@HarHarLinks
see if ubuntu runner works
0ea88c0 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
upgrade to bookworm to support s390x
08712b4 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
deep checkout element web when building container
a2f5171 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks HarHarLinks force-pushed the nic/feat/PX4-85-widgetready branch from f6c76ad to a2f5171 Compare November 20, 2024 15:33
@HarHarLinks
element-web (sentry) does not supper s390x anyway
e74ad66 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
needs longer CI time
d0799bc 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
weeman1337
weeman1337 requested changes Nov 21, 2024
View reviewed changes
.github/workflows/element-with-modules.yml Show resolved Hide resolved
.github/workflows/element-with-modules.yml Show resolved Hide resolved
.github/workflows/element-with-modules.yml Show resolved Hide resolved
.github/workflows/element-with-modules.yml Outdated Show resolved Hide resolved
.github/workflows/element-with-modules.yml Outdated Show resolved Hide resolved
e2e/src/deploy/elementWeb/Dockerfile Show resolved Hide resolved
@HarHarLinks
add default versions to manual runs
e1175ae 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
rename steps based on PR feedback
5d95f79 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks
add docs explaining the job matrix
da2f71d 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@helletheone helletheone removed their request for review November 21, 2024 09:55
@HarHarLinks
comment the usage of the dockerfile
1444d90 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@weeman1337 weeman1337 self-requested a review November 21, 2024 10:05
@HarHarLinks
add readme comment about reusing the dockerfile
6d336e4 
Signed-off-by: Kim Brose <kim.brose@nordeck.net>
@HarHarLinks HarHarLinks enabled auto-merge (squash) November 21, 2024 10:11
@HarHarLinks HarHarLinks merged commit 54f75f3 into main Nov 21, 2024
8 checks passed
@HarHarLinks HarHarLinks deleted the nic/feat/PX4-85-widgetready branch November 21, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarHarLinks @helletheone @weeman1337