[Suggestion] Make cursor blink toggleable

[zovt]

Currently, I have a fork that disables cursor blink. It would be preferable if the blink was a feature that could be toggled in a configuration option.

I can implement this, but I won't get around to it until the weekend.

[arcticicestudio]

👍 Yes, I totally agree. This should be toggeable to not override user preferences or force users to use this feature.
I'll go for it tomorrow evening.

[zovt]

👍 excellent! Thanks 😄

[arcticicestudio]

I've implemented a configuration attribute to set the cursor blinking feature.
It can be tested by checking out 🌱 feature/ghi-#7-make-cursor-blink-toggleable.

Information on how to configure Nord Hyper can be found in the configuration section in the README.

[zovt]

Excellent! When will this be released?

[arcticicestudio]

I'll merge it into develop, wait for the CI builds and prepare the next release version to push it to NPM.

[arcticicestudio]

🚢 Shipped in release version 🏷 0.3.0 and pushed as NPM 📦 package update.

[zovt]

I think hyper just released a new version that includes some built in option for cursor blinking. Maybe it would make sense to check that option instead?

[arcticicestudio]

Yeah, I've saw a proposal issue in the Hyper repository for it, but I did not expect it to be implemented that quickly.

I tested the new Hyper cursorBlink option, but I don't really like it. In my opinion the blink time is too long which makes the cursor look unresponsive and the animation/transition is more a kind of "hard cut" instead of fading out.
Anyway, it seems like both options can be enabled at the same time without problems.
The Nord cursorBlink option seem to be loaded after the built-in cursorBlink option which overrides it so users can choose which cursor blink style they want to use.

As long as there are no problems it should be fine to keep this config, but if problems occur I'll remove it again 😄