Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] doc improvement #161

Merged
merged 1 commit into from Jul 21, 2019
Merged

[WIP] doc improvement #161

merged 1 commit into from Jul 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2019

adds missing space. please do not merge as I will update this PR as I progress through docs.

@ghost ghost requested a review from svengreb as a code owner June 22, 2019 21:09
@arcticicestudio arcticicestudio self-requested a review June 23, 2019 05:08
@arcticicestudio arcticicestudio assigned ghost Jun 23, 2019
@arcticicestudio
Copy link
Contributor

Hi @mosn 👋, thanks in advance for your contribution 👍
Even though I use VS Code with spell checking extensions and the CI/CD pipelines using the remark-lint Markdown style guide rule set there are still some small typos and grammar issues. Haven't got the time and focus to fix them so I really appreciate every help 😄

@ghost
Copy link
Author

ghost commented Jun 23, 2019 •
edited by ghost
Loading

Hey @arcticicestudio That's the only thing I can do face the empire of perfection.
As mentioned I am going through all the docs to familiarize myself with the setup and will update this PR as I progress. 🙏 sorry for the silly PR :)

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jul 21, 2019 •
edited
Loading

@mosn There are no silly PRs, every contribution counts and should be treated with respect since someone put effort into it. It this PR still WIP or ready to be merged?

@arcticicestudio arcticicestudio added this to the Next milestone Jul 21, 2019
@ghost
Copy link
Author

ghost commented Jul 21, 2019

@arcticicestudio as of #160 I am up to date and LGTM. So we can close it.

@arcticicestudio arcticicestudio merged commit 453601e into nordtheme:develop Jul 21, 2019
@arcticicestudio arcticicestudio unassigned ghost Jul 21, 2019
@ghost ghost deleted the patch-1 branch October 16, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
context-documentation scope-quality type-improvement
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb