Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in vim plugin support section #172

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Fix typo in vim plugin support section #172

merged 2 commits into from
Jul 31, 2019

Conversation

ecklf
Copy link
Contributor

@ecklf ecklf commented Jul 31, 2019

Removing additional gr before vim-go link

https://www.nordtheme.com/ports/vim

@ecklf ecklf requested a review from svengreb as a code owner July 31, 2019 10:46
@arcticicestudio arcticicestudio self-requested a review July 31, 2019 13:24
@arcticicestudio arcticicestudio added this to the Next milestone Jul 31, 2019
svengreb
svengreb previously approved these changes Jul 31, 2019
View reviewed changes
arcticicestudio
arcticicestudio approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @impulse 👋, thanks for your contribution 👍

LGTM 😄

@arcticicestudio arcticicestudio requested a review from svengreb July 31, 2019 13:36
@ecklf
Copy link
Contributor Author

ecklf commented Jul 31, 2019

Woops hit the resolve too early. Added the missing "and" (prettier removed it with quick fix lol). Sorry couldn't test this locally due to #173

arcticicestudio
arcticicestudio approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we're good to go, thanks 😉
I'll write up a small summary about the problem in #173.

@arcticicestudio arcticicestudio merged commit fd3f895 into nordtheme:develop Jul 31, 2019
@arcticicestudio arcticicestudio removed their assignment Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcticicestudio arcticicestudio arcticicestudio approved these changes

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-documentation scope-quality scope-ux type-bug
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ecklf @arcticicestudio @svengreb