Remove dependency on grep in README + Improve findstr command #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
I'm a bit blind on the support for Windows as it's not included in our CI, as long as it doesn't break the other system support, and it looks raisonnable, I'll let you investigate. |
pomerlef
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it's me again.
First of all, I have removed the dependency on grep in the README.
I have also slightly improved yesterday's PR #120.
The current solution with findstr is fully functional, but it has a little difference with the solution using grep.
Due to a strange behaviour of
execute_process(COMMAND ...)on Windows, the following two lines are returned by findstr, whereas only the first one is returned if the command is run directly in the shell.However, this did not cause any problem as
string(REGEX REPLACE ...)still managed to find the correct version.I asked the question on Stackoverflow (link), and the solution off this PR was found.