Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linabo-build-system #130

Conversation

RedLeader962
Copy link
Contributor

@RedLeader962 RedLeader962 commented Jan 9, 2024

Description

Summary:

Add norlab-build-system library support. libnabo now have a build infrastructure agnostic build system which can be run on continuous integration infrastructure such as github-action or TeamCity Continuous Integration server. It can also be run localy to improve developement workflow. It support multi-architecture and multi-os version build.
There is also new installer script for ubuntu

Changes and type of changes (quick overview):

  • build: add git submodule N2ST and NBS [NMO-464]
  • feat: integrate norlab-build-system library and implement linabo-build-system [NMO-405]
  • feat: implement docker image (refactor libpointmatcher-dependencies images) [NMO-406]
  • ci: setup teamcity libnabo project [NMO-407]
  • ci: setup norlab/libnabo repository branching scheme [NMO-408]
  • docs: write contributiong section in readme or add contributing.md [NMO-466]
  • build: Added norlab-build-system submodule to repository [NMO-405]
  • chore: added a code owner designation file, a pull request template and a conventional commit
    reference file

Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check contributing/contributing_instructions.md for local testing procedure using libnabo-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding types
    (See contributing/commit_msg_reference.md for details)

Copy link
Contributor

@boxanm boxanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍 I'd consider running find and replace for any leftover libpointmatcher keywords and old version numbers (1.0.7 was the last release, I believe)

@RedLeader962
Copy link
Contributor Author

RedLeader962 commented Jan 10, 2024

@boxanm For tag mention in bats tests, we can't change references to the latest release tag (1.0.7) as there is test logic that require fetching an actual released version. For bash script, the one mentioned in libnabo_installer.bash header documentation is there just as an examples of the proper pattern to pass as argument. The two places where we need to bump the version number (ie package.xml and nabo.h) will be modified at the final release step.

Thanks for spotting the last sneaky libpointmatcher from the codebase, I've renamed it to test_dotenv_libnabo.bats.

boxanm
boxanm previously approved these changes Jan 10, 2024
@RedLeader962
Copy link
Contributor Author

I've also made minor style change in Dockerfile.libnabo.integration_test and docker-compose.libnabo.yaml so that it be intuitive i.e. change .*compilation_test.* to .*integration_test*

I'll push the commit tonight

@RedLeader962 RedLeader962 merged commit 54dc055 into develop Jan 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants