fix: add missing extension to sed flag seek_and_modify_string_in_file…

… for portability (mac OsX)
norlab-ulaval · Jan 24, 2024 · a70b6f9 · a70b6f9
1 parent cf72db1
commit a70b6f9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/function_library/general_utilities.bash b/src/function_library/general_utilities.bash
@@ -50,8 +50,9 @@ function n2st::seek_and_modify_string_in_file() {
 
   # Note:
   #   - Character ';' is used as a delimiter
-  #   - Keep -i flag for portability to Mac OsX
-  sudo sed -i "s;${TMP_SEEK};${TMP_CHANGE_FOR};" "${TMP_FILE_PATH}"
+  #   - Keep -i flag for portability to Mac OsX (it's analogue to --in-place flag)
+  #   - .bak is the backup extension convention and is required by -i
+  sudo sed -i.bak "s;${TMP_SEEK};${TMP_CHANGE_FOR};" "${TMP_FILE_PATH}" && rm "${TMP_FILE_PATH}.bak"
 
 }
 

diff --git a/tests/test_general_utilities.bats b/tests/test_general_utilities.bats
@@ -94,6 +94,9 @@ teardown() {
 
   run n2st::seek_and_modify_string_in_file "${LOOKUP_STR}.*" "${MODIFIED_STR}" "$TMP_TEST_FILE"
   assert_success
+
+  assert_file_exist "${TMP_TEST_FILE}"
+
   run n2st::preview_file_in_promt "$TMP_TEST_FILE"
   assert_output --partial "${UNCHANGED_STR}"
   refute_output --partial "${ORIGINAL_STR}"