Skip to content

Commit

Permalink
fix docker build instruction for docker-container driver (#76)
Browse files Browse the repository at this point in the history
# Description
### Summary:

Add load flag 




### Changes and type of changes (quick overview):

- 
- 
- 


---

# Checklist:

### Code related
- [ ] I have made corresponding changes to the documentation (i.e.:
function/class, script header, README.md)
- [ ] I have commented hard-to-understand code 
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] All tests pass locally with my changes (Check `tests/README.md`
for local testing procedure)
- [x] My commit messages follow the [conventional
commits](https://www.conventionalcommits.org) specification. See
`commit_msg_reference.md` in the repository root for details

### PR creation related 
- [x] My pull request `base ref` branch is set to the `dev` branch (the
_build-system_ won't be triggered otherwise)
- [x] My pull request branch is up-to-date with the `dev` branch (the
_build-system_ will reject it otherwise)

### PR description related 
- [x] I have included a quick summary of the changes
- [x] I have indicated the related issue's id with `# <issue-id>` if
changes are of type `fix`

 ## Note for repository admins
 ### Release PR related
- Only repository admins have the privilege to `push/merge` on the
default branch (ie: `main`) and the `release` branch.
- Keep PR in `draft` mode until all the release reviewers are ready to
push the release.
- Once a PR from `release` -> `main` branch is created (not in draft
mode), it triggers the _build-system_ test
- On merge to the `main` branch, it triggers the _semantic-release
automation_
  • Loading branch information
RedLeader962 authored Mar 21, 2024
2 parents c30fb4f + 3c24301 commit a9bc555
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/semantic_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "lts/*"
node-version: "latest"
- name: Install semantic-release
run: npm install --save-dev semantic-release
- name: Install semantic-release additional plugins (git)
Expand Down
2 changes: 2 additions & 0 deletions tests/bats_testing_tools/run_bats_tests_in_docker.bash
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ docker build \
--build-arg "TEAMCITY_VERSION=${TEAMCITY_VERSION}" \
--file "${N2ST_BATS_TESTING_TOOLS_ABS_PATH}/Dockerfile.bats-core-code-isolation.${BATS_DOCKERFILE_DISTRO}" \
--tag n2st-bats-test-code-isolation/"${PROJECT_GIT_NAME}" \
--platform "linux/$(uname -m)" \
--load \
.

if [[ ${TEAMCITY_VERSION} ]]; then
Expand Down

0 comments on commit a9bc555

Please sign in to comment.