Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make portable seek_and_modify_string_in_file (mac OsX) #74

Merged

Conversation

RedLeader962
Copy link
Contributor

Description

Summary:

n2st::seek_and_modify_string_in_file was not portable. MacOsx implementation of sed does not have a --in-place flag. Refactor using -i


Checklist:

Code related

  • I have made corresponding changes to the documentation (i.e.: function/class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes (Check tests/README.md for local testing procedure)
  • My commit messages follow the conventional commits specification. See commit_msg_reference.md in the repository root for details

PR creation related

  • My pull request base ref branch is set to the dev branch (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the dev branch (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix

Note for repository admins

Release PR related

  • Only repository admins have the privilege to push/merge on the default branch (ie: main) and the release branch.
  • Keep PR in draft mode until all the release reviewers are ready to push the release.
  • Once a PR from release -> main branch is created (not in draft mode), it triggers the build-system test
  • On merge to the main branch, it triggers the semantic-release automation

@RedLeader962 RedLeader962 merged commit d94064c into dev Jan 24, 2024
1 check passed
RedLeader962 pushed a commit that referenced this pull request Jan 24, 2024
## [2.1.3](v2.1.2...v2.1.3) (2024-01-24)

### Bug Fixes

* make portable seek_and_modify_string_in_file (mac OsX) ([c19a80a](c19a80a))
* make portable seek_and_modify_string_in_file (mac OsX) ([#74](#74)) ([d94064c](d94064c))
@RedLeader962
Copy link
Contributor Author

🎉 This PR is included in version 2.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant