-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests and benches #43
Tests and benches #43
Conversation
Also use the new resolver=2 feature resolver for the amethyst dependencies
Thanks for the fixes. I have one change that like to ask you, because you splitted the benches from single entry point to individual ones, maybe should remove the benchmarks module and move the code to each entry point. |
Sure I was debating that with myself but thought I'd try to keep the diff to a minimal |
I have made the change and I am running the benches now to make sure I didn't break anything |
Ok Done! |
By the way the whole reason I did this was because I wanted to test the benches. I had a chunk where depth, width and height were expensive functions calls and the voxel baker was calling them often as you can see here: let x_limit = chunk.width() as usize - 1;
let y_limit = chunk.height() as usize - 1;
let z_limit = chunk.depth() as usize - 1;
for x in 0..chunk.width() as usize {
for y in 0..chunk.height() as usize {
for z in 0..chunk.depth() as usize { For large chunks (600 voxels per dimension) the functions |
I am going to add another bench mark using a chunk with a 3d checkerboard:
This should resemble a chunk that requires maximum work to bake as their are 6 unique edges per vertex. |
This should get all the tests and benches working for the recent changes.
I have gone and used the
resolver=2
feature resolver so thatamethyst/metal
or vulkan dependencies auto enable based on the os. This is a new feature that has only recently been stabalised so may need to use the latest rust. Rust stablise PR is here