Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer Draw #4837

Closed
Durman opened this issue Dec 22, 2022 · 2 comments
Closed

Viewer Draw #4837

Durman opened this issue Dec 22, 2022 · 2 comments
Labels
bug 🐛

Comments

@Durman
Copy link
Collaborator

Durman commented Dec 22, 2022

Problem statement

Viewer Draw node can crush Blender (at least in 3.4.0).

image

untitled.blend.zip
@satabol
Copy link
Collaborator

satabol commented Dec 22, 2022 •
edited
Loading

I reproduce error:

image

Crash is not good but expected in this situation. Proposal is to check geom.v_vertices length for first vertex. If first point has three digits and other are not then no crash and only errors in console:
image

If set this rules then no crash happens:
image

May be zero check is not enough (?)
image
(No crash)

@satabol satabol mentioned this issue Dec 23, 2022
Merged
@satabol satabol mentioned this issue Jan 16, 2023
Closed
@satabol
Copy link
Collaborator

satabol commented Jan 19, 2023

@Durman , hello. Can you see fix for this issue?

satabol added a commit that referenced this issue Jul 18, 2023
@satabol
Merge pull request #4838 from nortikin/viz-viewr_draw_mk4_fix_4837
2d9e313 
fix #4837 (crash Blender if only first vertex in vertices list is empty)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@satabol @Durman