Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Interpolate NURBS Curve" node - FreeCAD implementation #4887

Closed
rendetto opened this issue Feb 2, 2023 · 5 comments
Closed

"Interpolate NURBS Curve" node - FreeCAD implementation #4887

rendetto opened this issue Feb 2, 2023 · 5 comments

Comments

@rendetto
Copy link
Contributor

rendetto commented Feb 2, 2023

I started working on this implementation. It doesn't have metrics originally but I plan to add the usual ones.

Interpolate_NURBS_Curve_Node_add_FreeCAD

@rendetto
Copy link
Contributor Author

rendetto commented Feb 5, 2023

One step ahead. The option "Cyclic" now works:

CyclicFreeCAD

@rendetto
Copy link
Contributor Author

rendetto commented Feb 6, 2023

PR #4889 is ready for review. Unfortunately the option of setting "EndPoint Tangent constraints" has a bug and it's not usable in it's current state. So it's not supported at this stage. All the other options are available.

EDIT: The option of switching on and off the individual per point tangents is also unavailable because the result seems affected from the above mentioned bug.

@rendetto
Copy link
Contributor Author

rendetto commented Feb 8, 2023

It turns out that there is an undocumented interpolation parameter in FreeCAD. This parameter I found in OCCT documentation and it affects how tangents are calculated. So the above statement that there is a bug is not true.

I'm up to implement all the missing options including "EndPoints Tangent constraints" and "PerPoint Tangents ON/OFF Flags"

@rendetto
Copy link
Contributor Author

rendetto commented Feb 11, 2023

I updated the PR. Now all options are available.

interpolate_freecad_options

@rendetto
Copy link
Contributor Author

The above changes are merged into master :)
I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant