"Interpolate NURBS Curve" node - FreeCAD implementation #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rendetto
changed the title
...with auto-masking and auto-scaling
|
@portnov can you please take a look? I finished testing most of the cases it will encounter. So it should be ready for merge. Thanks |
|
Oops! I started getting errors after merging master here. What can I do to solve those? EDIT: Never mind, seems I fixed it :) |
|
The node is fully operational. If there are no concerns for this PR it can be merged. |
|
@portnov Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the interpolation method from FreeCAD/OCCT. It supports standard parametrization metrics, custom knots, per point tangents and can create open and smoothly closed curves. Also it is very fast and stable and can deal with thousands of points.
Here are some examples of the options available:
Interpolate to cyclic curve using Euclidean metric
Interpolate to open curve with constrained start and end tangents
Interpolate to cyclic curve using full tangent constraints and custom knots
