Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Gcode Exporter" and "Evaluate Image" #2298

Merged
merged 16 commits into from
Nov 8, 2018

Conversation

alessandro-zomparelli
Copy link
Collaborator

Addressed problem description

Gcode generation for 3D printing (still in the Beta group, because it needs more tests on different machines. So far it works fine)
Added "Evaluate Image Node"
Fixed "Image Node" limit to 100

Preflight checklist

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@nortikin
Copy link
Owner

nortikin commented Nov 1, 2018

not sure if this is ready to merge, need try.
I don't handle Gcode, maybe it is easy, but not today

@alessandro-zomparelli
Copy link
Collaborator Author

Sure, take your time.
I've moved the Gcode Node from Alpha to Beta, because I've completed it, but I think that it should be stay in Beta until more test will be done.
So far I have test it directly with only one printer and just compared with Cura with specific settings. The extrusion parameters seems correct, but I'm not sure 100%.

nodes/text/export_gcode.py Outdated Show resolved Hide resolved
nodes/text/export_gcode.py Outdated Show resolved Hide resolved
@zeffii
Copy link
Collaborator

zeffii commented Nov 8, 2018

i'm happy to merge this :) will need other minor changes for 2.8. lateron

@alessandro-zomparelli
Copy link
Collaborator Author

i'm happy to merge this :) will need other minor changes for 2.8. lateron

Thanks! I'll start tomorrow a 3 day workshop printing Clay with Sverchok, I think this will be a good stress test :)

@zeffii
Copy link
Collaborator

zeffii commented Nov 8, 2018

cool! please share photos here. (direct upload.. so we don't have to have a facebook/instagram account etc..) - help get people interested :]

@alessandro-zomparelli
Copy link
Collaborator Author

cool! please share photos here. (direct upload.. so we don't have to have facebook/instagram account etc..) - help get people interested :]

Sure, I'll do!
Just one stupid question, should I merge it myself, or you guys have some other checks that you would like to do?

immagine

It's my first contribute to a larger repository and I'm not sure on how to proceede now :-P

@zeffii
Copy link
Collaborator

zeffii commented Nov 8, 2018

change the big green button (using the dropdown button [ v ] ) to "Squash and Merge", that way all the changes appear in one merged PR. then hit

image

@alessandro-zomparelli alessandro-zomparelli merged commit 33af0e1 into nortikin:master Nov 8, 2018
@alessandro-zomparelli
Copy link
Collaborator Author

Thank you very much @zeffii !

@alessandro-zomparelli
Copy link
Collaborator Author

Hi guys,
this was my first workshop with Sverchok+Clay 3D printing, and it goes really well :-)
I've only spotted a small issue with Evaluate Image, but a minor thing, I'll try to replicate and I'll add it to the issues. Also I spotted a minor issue with Spiral generating Vertices as Lists instead of Tuples (I passed them to an empty Matrix Apply for converting them).

I had the chance to stress the gcode exporter with PLA (plastic filament) and it worked perfectly, so happy about that. Sverchok worked great as well. Here you can see some photos of the printed objects:

img_0402
img_0403
img_0405
img_0406
img_0411
img_0412
img_0414
img_0439
img_0481
img_0484
img_0496

@zeffii
Copy link
Collaborator

zeffii commented Nov 12, 2018

hands down the coolest sverchok-related artwork i've seen so far :) thank you immensely for sharing.

@zeffii
Copy link
Collaborator

zeffii commented Nov 12, 2018

would love to see these glazed and fired. : )

@alessandro-zomparelli
Copy link
Collaborator Author

Thank you very much @zeffii !
We have glazed some vases made with Sverchok before. You can find the pictures in my Instagram, it's a public profile, no registration is needed: https://www.instagram.com/alessandro_zomparelli/
And here: https://www.instagram.com/stories/highlights/17942796004146281/

@vicdoval
Copy link
Collaborator

@alessandro-zomparelli this nodes are not in the b28_prelease_master branch wouldn't you like to make the migration?

@vicdoval vicdoval added this to the 2.80 Nice-to-Have milestone Nov 24, 2019
@nortikin nortikin mentioned this pull request Mar 2, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants