Added "BW" Grayscale and "A" Alpha channel support #2314
Conversation
Updating Fork
nodes/analyzer/evaluate_image.py
Outdated
| else: | ||
| red[0].append(0) | ||
| green[0].append(0) | ||
| blue[0].append(0) | ||
| alpha[0].append(0) | ||
| if outputs['BW'].is_linked: | ||
| bw[0] = [(r+g+b)/3 for r,g,b in zip(red[0], green[0], blue[0])] |
There was a problem hiding this comment.
(r+g+b)/3 ?
not to be picky but...
https://en.wikipedia.org/wiki/Grayscale
There was a problem hiding this comment.
You are not picky, it's my bad. I was to hurried :P, I'll fix that ;)
|
adding sockets at the top of the socket list (either inputs or outputs) will break layouts that contain versions of the node before the update, best practice is to add sockets to the end of the socket lists. UI coding is the painful part of nodes :) |
Thanks for pointing out, I didn't know that. |
| green = [[]] | ||
| blue = [[]] | ||
|
|
||
| if outputs['R'].is_linked or outputs['G'].is_linked or outputs['B'].is_linked: | ||
| if outputs['R'].is_linked or outputs['G'].is_linked or outputs['B'].is_linked or outputs['A'].is_linked or outputs['BW'].is_linked: |
There was a problem hiding this comment.
if any(socket.is_linked for socket in self.outputs):
...There was a problem hiding this comment.
That's magic :D
Unfortunately I'll be on vacation for two weeks (Mexico with no PC). I will be able to handle that only at beginning of December. If you want to fix that in the meanwhile, fell free to modify it. Otherwise I'll take care of it when I'll be back.
|
ok. i'll leave it for now. merged anyway. |
|
done. |
Addressed problem description
Based on the suggestion of @enzyme69 I added two more output sockets for grayscale and alpha channel
Preflight checklist
Put an x letter in each brackets when you're done this item: