Add scale/multiplier to TextureViewerLite node to fix rendering #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port the same preference settings for xy/scale into the TVL node to fix the location and the size of the rendering.
6 tasks
|
Btw, is it just me or the two colors (the selected color in the Color input node and the output of the TVL node) are different ? Could it be the BGL rendering is not doing the same gl composition as the CI node ? The TVL output seems a bit darker. |
|
yep different, which to be honest I would expect in |
|
in 2.80 it seems to swing the other way, it's waay brighter. Not sure what to do about that @DolphinDream |
I wonder if it’s related to the color management module in Blender. |
|
any objections to merging this into master? |
|
nope. work away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the same preference settings for xy/scale into the TVL node to fix the location and the size of the rendering.
Before..
After...