-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SvRecursiveNode mixin #3954
Merged
Merged
SvRecursiveNode mixin #3954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a new one post-processing mode: |
I was testing my old layouts and found that shape of output data of Merge by distance node cause an error in next nodes. Most likely this PR made backward incapable changes. |
Durman
added a commit
that referenced
this pull request
Sep 9, 2021
new version of the node had to be created
Durman
added a commit
that referenced
this pull request
Sep 13, 2021
…istance Revert: SvRecursiveNode mixin (#3954)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Introduces a Mixin to create multi-level recursive nodes.
When used the nesting properties have to be defined in the sv_init function
After the data is processed in the process_data function
As example a have implemented it in 4 nodes:
Vector Polar Output, Calculate Normals, Mesh Join and Merge by distance
but i did not remove the originals nodes to compare them in case someone wants to add some idea to the PR (otherwise i will remove them soon)This implementation leaves out of the nodes code sv_get and sv_set functions and allows the coder to work only with the needed levels of nesting.