matrix out format fix #4003
Merged
matrix out format fix #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Durman
reviewed
Mar 31, 2021
node_tree.py
Outdated
| @@ -322,6 +322,11 @@ def init(self, context): | |||
| sys.stderr.write('ERROR: %s\n' % str(err)) | |||
| self.set_color() | |||
|
|
|||
| def sv_new_input(self, socket_type, name, attrib_dict): | |||
There was a problem hiding this comment.
Suggested change
| def sv_new_input(self, socket_type, name, attrib_dict): | |
| def sv_new_input(self, socket_type, name, **attrib_dict): |
As to me it would be a little bit more flexible.
It will be still possible to use dictionary self.sv_new_input(**{'attribute': value})
and in the same time you have option to pass attributes as normal parameters self.sv_new_input(attribute=value)
Durman
reviewed
Mar 31, 2021
nodes/matrix/matrix_out_mk2.py
Outdated
| @@ -80,7 +85,7 @@ def update_mode(self, context): | |||
| items=mode_items, default="AXISANGLE", update=update_mode) | |||
|
|
|||
| def sv_init(self, context): | |||
| self.inputs.new('SvMatrixSocket', "Matrix").is_mandatory =True | |||
| self.sv_new_input('SvMatrixSocket', "Matrix", dict(is_mandatory=True, nesting_level=2)) | |||
There was a problem hiding this comment.
Suggested change
| self.sv_new_input('SvMatrixSocket', "Matrix", dict(is_mandatory=True, nesting_level=2)) | |
| self.sv_new_input('SvMatrixSocket', "Matrix", is_mandatory=True, nesting_level=2) |
I see this as more convenient API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format fix for matrix_out mk2.
Flat Quaternions Output option to keep them in the original format that can be disabled or wont be used when inputing list of list of matrices
also in this PR:
a method added to the nodes to assing properties to the input sockets via dictionary, (suggestion from @zeffii)
now you can use as example:
self.sv_new_input('SvVerticesSocket', 'Vectors', dict(prop_name='Vector', is_madatory=True))