Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component analyzer upgrade #4033

Merged
merged 6 commits into from
Apr 10, 2021

Conversation

vicdoval
Copy link
Collaborator

@vicdoval vicdoval commented Apr 9, 2021

In the component analyzer :
Numpy routines for Faces and Vertex Normals, Centers, Perimeter and Tangent Edge
This are the results of some test


Icosphere 8 subdivisions
    center median
        Old     0.682  
        New     0.224  
    center bbox
        Old     0.665  
        New     0.369 
    center weighted
        Old     0.668  
        New     0.375 
        
    normals
        Old     0.621  
        New     0.316  
    normals absolute
        Old     0.697  
        New     0.353  

    perimeter
        Old     0.615  
        New     0.182  

    tangent edge
        Old 0.668
        New 0.321

10000 faces voronoi sphere (variable polygon sides)
    center median
        Old     0.037  
        New     0.018  
    center bbox
        Old     0.035  
        New     0.026  
    center weighted
        Old    0.033  
        New    0.022  

    normals
        Old     0.032  
        New     0.020  
    normals absolute
        Old     0.034  
        New     0.028  

    perimeter
        Old     0.031  
        New     0.017  

    tangent edge
        Old     0.034
        New     0.018

    vertex normals
        Old     0.036
        New     0.025

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@vicdoval vicdoval linked an issue Apr 10, 2021 that may be closed by this pull request
@vicdoval vicdoval merged commit 97b32c9 into nortikin:master Apr 10, 2021
@vicdoval
Copy link
Collaborator Author

I have just discovered I added a different algorithm Vertex Normal Algorithm

"Mean Weighted Equally” (MWE) algorithm, was
introduced by Henri Gouraud[1] in 1971

https://www.researchgate.net/publication/220067106_A_comparison_of_algorithms_for_vertex_normal_computation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge by distance Node, must permit Vertex only input.
2 participants