Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend cleanups (licence, SvGenericNodeLocator..) #4070

Merged
merged 25 commits into from
May 3, 2021

Conversation

zeffii
Copy link
Collaborator

@zeffii zeffii commented May 2, 2021

Some operators are called from buttons which are located in a Blender UI space which does not track the context.node, (the origin of the click is undefined). The node.wrapper_tracked_ui_draw_op wrapper is an alternative for those nodes that do need extra origin tracking - the wrapper passes the node's node.id_data.name and node.name behind the scenes. Most nodes don't need this, until they do.

This PR commits a few backend cleanups

  • makes operators that do need to track the click-origin use SvGenericNodeLocator mixin, this simplifies the transition away from idtree and idname. These are some of the oldest variable names in sverchok :) it's time they get more obvious names
self.idtree    -> self.tree_name
self.idname    -> self.node_name

along the way i'll also change a few node license blurbs to the abbreviated version.


  • ...sverchok\nodes\list_mutators\multi_cache.py
  • ...sverchok\nodes\logic\evolver.py
  • ...sverchok\nodes\logic\genes_holder.py
  • ...sverchok\nodes\network\file_path.py
  • ...sverchok\nodes\scene\objects_mk3.py
  • ...sverchok\nodes\solid\export_solid.py
  • ...sverchok\nodes\svg\svg_document.py
  • ...sverchok\nodes\viz\viewer_waveform_output.py
  • ...sverchok\utils\sv_3dview_tools.py
  • ...sverchok\utils\sv_obj_baker.py
  • ...sverchok\utils\sv_operator_utils.py
  • extensively tested

@zeffii zeffii changed the title change touched licences backend cleanups (licence, SvGenericNodeLocator..) May 2, 2021
@zeffii zeffii merged commit 0024862 into master May 3, 2021
@zeffii zeffii deleted the node_trackers_homogenized branch July 5, 2021 16:51
Durman added a commit to Durman/ladybug-blender that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant