New structure for JSON files and new approach of adding changes into the JSON format #4118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but particular in this case I did not think about back capability because JSON files of this format was not created yet
…nd add pointer type property. This changes are required by new JSON serialization module
…ut and output nodes. They have dynamic modifiers which are determine when interface sockets of group tree are creating. Solution was to keep socket identifiers in similar way as new socket names. For Group input and output nodes there is decision not saving their sockets. Data blocks of pointer properties, export of that is not supported, are ignored during export. Also fixing some bugs.
…ructures, fix some load_from_json methods according to new importer
…pporting can be added easily but group input/output nodes should be excluded from exported nodes because in other way they can get into a normal tree during an import. Also for preset panel node group tree should get extra properties. Probably I did not switched off in all possible places (context menus?)
# Conflicts: # json_examples/Advanced/Pineapple.json # node_tree.py # utils/__init__.py
zeffii
reviewed
Jun 8, 2021
| @@ -199,6 +185,7 @@ def draw(self, context): | |||
| col = self.layout.column() # old syntax in <= 2.83 | |||
|
|
|||
| col.use_property_split = True | |||
| col.prop(self, 'compact') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed problem description
This PR should make it easier to add new features into JSON format like saving mesh data blocks, text script files etc.
Also it adds supporting serialization of
node groupsinto JSONcloses #4096 #4100
What's new:
Preflight checklist