Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove curvemapper from snlite #4162

Merged
merged 33 commits into from
Jun 12, 2021
Merged

remove curvemapper from snlite #4162

merged 33 commits into from
Jun 12, 2021

Conversation

zeffii
Copy link
Collaborator

@zeffii zeffii commented Jun 11, 2021

some snlite pruning.

  • removing old directive (curvemapper is now a proper node)
    • also removing all associated functions from helper files, they are now part of the curvemapper files.
  • adding alternative parsing for required sockets
    """
    >in socketname type   # for required linked sockets  (no default, no nested specification)
    ...etc
    """
    this > is also a hint to the reader that these sockets are necessary for the code to function. Not all script node scripts will need this, but for the scripts you include in json/examples you might want to add this, it also keeps the testing suite happy.

@zeffii zeffii marked this pull request as draft June 11, 2021 11:04
@zeffii
Copy link
Collaborator Author

zeffii commented Jun 11, 2021

there are a few ways to do this via the directive, i could be something like these:

i like this, it's really short. , using the less than symbol

>in socketname type   # for required linked sockets

this is more descriptive, so nice for newcomers, but verbose after the first encounter with the concept. academic : /

in socketname type (required)
in socketname type (r)   # shorthand

in these options, you don't need to keep track of renaming sockets.
another option would be

in socketname type
in socketname type
in socketname type
out socketname type
...etc
required=(socketname, socketname.... )

and i sure as hell am not going to be typing that.

@zeffii zeffii marked this pull request as ready for review June 12, 2021 12:05
@zeffii zeffii merged commit da35f41 into master Jun 12, 2021
@zeffii zeffii deleted the snilte_new_directive branch July 5, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant