Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nurbs birail update 2 #4177

Merged
merged 3 commits into from
Jun 20, 2021
Merged

Nurbs birail update 2 #4177

merged 3 commits into from
Jun 20, 2021

Conversation

portnov
Copy link
Collaborator

@portnov portnov commented Jun 20, 2021

Add a parameter which controls rotation of profile curves.

  • Path Normal Average. The node will try to place profile curves so that
    they will lie in normal planes of both path curves. Since normal planes of
    two path curves can differ, the node will calculate average normal plane.
  • Path 1 Normal. The node will place profile curves so that they lie in
    normal plane of the first path curve.
  • Path 2 Normal. The node will place profile curves so that they lie in
    normal plane of the second path curve.
  • By profile. The node will try to place profile curves so that they be
    parallel to initial location of the path curve. This is not always
    possible, but the node will try to keep it as parallel as possible.

The default option is Path Normal Average.

Screenshot_20210620_112703
Screenshot_20210620_112632
Screenshot_20210620_112548
Screenshot_20210620_112521

Preflight checklist

Put an x letter in each brackets when you're done this item:

  • Code changes complete.
  • Code documentation complete.
  • Documentation for users complete (or not required, if user never sees these changes).
  • Manual testing done.
  • Unit-tests implemented.
  • Ready for merge.

@portnov portnov added the NURBS label Jun 20, 2021
@portnov portnov merged commit 5bc1be6 into master Jun 20, 2021
@rendetto
Copy link
Contributor

Thank you for this cool update! I'll start exploring the options.
What settings will recreate the behavior of the node before the update?

@portnov
Copy link
Collaborator Author

portnov commented Jun 20, 2021

The default ones. We always try to preserve backward compatibility.

@rendetto
Copy link
Contributor

Perfect! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants